Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2439643003: Fix S3TC size validation for non-webgl contexts (Closed)

Created:
4 years, 2 months ago by piman
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix S3TC size validation for non-webgl contexts The (formerly) IsValidDXTSize check is specific to the WEBGL_compressed_texture_s3tc semantics, but doesn't correspond to constraints in the native extension (EXT_texture_compression_s3tc), so only apply this check to WebGL contexts. BUG=657678 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6b129d16c110e756516a7ce973faf5432224c4f1 Cr-Commit-Position: refs/heads/master@{#426529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -9 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 2 chunks +230 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
piman
4 years, 2 months ago (2016-10-20 03:04:43 UTC) #6
Zhenyao Mo
On 2016/10/20 03:04:43, piman wrote: lgtm Thanks for fixing this.
4 years, 2 months ago (2016-10-20 15:50:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439643003/1
4 years, 2 months ago (2016-10-20 18:00:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 18:05:41 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:20:08 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b129d16c110e756516a7ce973faf5432224c4f1
Cr-Commit-Position: refs/heads/master@{#426529}

Powered by Google App Engine
This is Rietveld 408576698