[Findit] Reduce redundant ndb reads by querying necessary entities ahead of time and share them amo…

appengine/findit/waterfall/test/suspected_cl_util_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 
 from common.waterfall import failure_type
 from model import analysis_approach_type
 from model import suspected_cl_status
 from model.suspected_cl_confidence import ConfidenceInformation
@@ skipping 386 matching lines @@
     self.assertIsNone(suspected_cl_util.GetSuspectedCLConfidenceScore(
         self.cl_confidences, build))
 
   def testGetConfidenceScoreTestNone(self):
     build = {
       'failure_type': failure_type.TEST,
       'approaches': []
     }
     self.assertIsNone(suspected_cl_util.GetSuspectedCLConfidenceScore(
         self.cl_confidences, build))
+
+  def testGetSuspectedCLConfidenceScoreAndApproachNone(self):
+    confidence, approach = (
+        suspected_cl_util.GetSuspectedCLConfidenceScoreAndApproach(
+            self.cl_confidences, None, None))
+    self.assertIsNone(confidence)
+    self.assertIsNone(approach)
+
+  def testGetSuspectedCLConfidenceScoreAndApproachUseFirstBuild(self):
+    build = {
+        'failure_type': failure_type.COMPILE,
+        'failures': None,
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.TRY_JOB],
+        'top_score': 5
+    }
+
+    first_build = {
+        'failure_type': failure_type.COMPILE,
+        'failures': None,
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.TRY_JOB,
+                       analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    confidence, approach = (
+        suspected_cl_util.GetSuspectedCLConfidenceScoreAndApproach(
+            self.cl_confidences, build, first_build))
+
+    self.assertEqual(
+        suspected_cl_util._RoundConfidentToInteger(
+            self.cl_confidences.compile_heuristic_try_job.confidence),
+            confidence)
+    self.assertEqual(
+        analysis_approach_type.TRY_JOB, approach)
+
+  def testGetSuspectedCLConfidenceScoreAndApproachUseNewStep(self):
+    build = {
+        'failure_type': failure_type.TEST,
+        'failures': {'a': [], 'b': []},
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    first_build = {
+        'failure_type': failure_type.TEST,
+        'failures': {'a': ['t1']},
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.TRY_JOB,
+                       analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    confidence, approach = (
+        suspected_cl_util.GetSuspectedCLConfidenceScoreAndApproach(
+            self.cl_confidences, build, first_build))
+
+    self.assertEqual(
+        suspected_cl_util._RoundConfidentToInteger(
+            self.cl_confidences.test_heuristic[1].confidence),
+            confidence)
+    self.assertEqual(
+        analysis_approach_type.HEURISTIC, approach)
+
+  def testGetSuspectedCLConfidenceScoreAndApproachUseNewTest(self):
+    build = {
+        'failure_type': failure_type.TEST,
+        'failures': {'a': ['t1', 't2']},
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    first_build = {
+        'failure_type': failure_type.TEST,
+        'failures': {'a': ['t1']},
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.TRY_JOB,
+                       analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    confidence, approach = (
+        suspected_cl_util.GetSuspectedCLConfidenceScoreAndApproach(
+            self.cl_confidences, build, first_build))
+
+    self.assertEqual(
+        suspected_cl_util._RoundConfidentToInteger(
+            self.cl_confidences.test_heuristic[1].confidence),
+            confidence)
+    self.assertEqual(
+        analysis_approach_type.HEURISTIC, approach)
+
+  def testGetSuspectedCLConfidenceScoreAndApproachUseLessTest(self):
+    build = {
+        'failure_type': failure_type.TEST,
+        'failures': {'a': ['t1']},
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    first_build = {
+        'failure_type': failure_type.TEST,
+        'failures': {'a': ['t1', 't2']},
+        'status': suspected_cl_status.CORRECT,
+        'approaches': [analysis_approach_type.TRY_JOB,
+                       analysis_approach_type.HEURISTIC],
+        'top_score': 5
+    }
+
+    confidence, approach = (
+        suspected_cl_util.GetSuspectedCLConfidenceScoreAndApproach(
+            self.cl_confidences, build, first_build))
+
+    self.assertEqual(
+        suspected_cl_util._RoundConfidentToInteger(
+            self.cl_confidences.test_heuristic_try_job.confidence), confidence)
+    self.assertEqual(
+        analysis_approach_type.TRY_JOB, approach)