Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: chrome/browser/win/enumerate_modules_model.cc

Issue 2439493002: Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager_interface.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/enumerate_modules_model.cc
diff --git a/chrome/browser/win/enumerate_modules_model.cc b/chrome/browser/win/enumerate_modules_model.cc
index 7d301ca42caf3f6ba0e4b28c6f3cddc371491014..f2a0c29825a5d054ffad0cb789b5211921c5594e 100644
--- a/chrome/browser/win/enumerate_modules_model.cc
+++ b/chrome/browser/win/enumerate_modules_model.cc
@@ -787,7 +787,8 @@ void EnumerateModulesModel::AcknowledgeConflictNotification() {
if (!conflict_notification_acknowledged_) {
conflict_notification_acknowledged_ = true;
- FOR_EACH_OBSERVER(Observer, observers_, OnConflictsAcknowledged());
+ for (Observer& observer : observers_)
+ observer.OnConflictsAcknowledged();
}
}
@@ -844,7 +845,8 @@ void EnumerateModulesModel::ScanNow(bool background_mode) {
// observers that the scan is complete. At this point |enumerated_modules_| is
// safe to access as no potentially racing blocking pool task can exist.
if (!enumerated_modules_.empty()) {
- FOR_EACH_OBSERVER(Observer, observers_, OnScanCompleted());
+ for (Observer& observer : observers_)
+ observer.OnScanCompleted();
return;
}
@@ -988,5 +990,6 @@ void EnumerateModulesModel::DoneScanning() {
confirmed_bad_modules_detected_);
// Forward the callback to any registered observers.
- FOR_EACH_OBSERVER(Observer, observers_, OnScanCompleted());
+ for (Observer& observer : observers_)
+ observer.OnScanCompleted();
}
« no previous file with comments | « chrome/browser/task_manager/task_manager_interface.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698