Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2439443002: [NTP Client] Make the SignInPromo update on SignInAllowed changes (Closed)
Patch Set: now philosophically correct Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index a9a97815aa8d9e14c07dfd1a5512885c787556a6..b316e77a766a5d66e213ea58d6cce3340c331d6e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -16,6 +16,7 @@
import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
@@ -26,7 +27,6 @@
import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;
import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;
import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;
-import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
import java.util.ArrayList;
import java.util.Collections;
@@ -140,22 +140,12 @@ public NewTabPageAdapter(NewTabPageManager manager, View aboveTheFoldView, UiCon
}
};
- mSigninPromo = new SignInPromo(mRoot);
+ mSigninPromo = new SignInPromo(mRoot, this);
+ DestructionObserver signInObserver = mSigninPromo.getObserver();
+ if (signInObserver != null) mNewTabPageManager.setDestructionObserver(signInObserver);
+
resetSections(/*alwaysAllowEmptySections=*/false);
mNewTabPageManager.getSuggestionsSource().setObserver(this);
-
- mNewTabPageManager.registerSignInStateObserver(new SignInStateObserver() {
- @Override
- public void onSignedIn() {
- mSigninPromo.hide();
- resetSections(/*alwaysAllowEmptySections=*/false);
- }
-
- @Override
- public void onSignedOut() {
- mSigninPromo.maybeShow();
- }
- });
}
/**

Powered by Google App Engine
This is Rietveld 408576698