Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/builtins/builtins.cc

Issue 2439013003: [builtins] Update TFJ macro to take actual argc (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/code-events.h" 6 #include "src/code-events.h"
7 #include "src/code-stub-assembler.h" 7 #include "src/code-stub-assembler.h"
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 #include "src/isolate.h" 10 #include "src/isolate.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 PostBuildProfileAndTracing(isolate, *code, name); 77 PostBuildProfileAndTracing(isolate, *code, name);
78 return *code; 78 return *code;
79 } 79 }
80 80
81 // Builder for builtins implemented in TurboFan with JS linkage. 81 // Builder for builtins implemented in TurboFan with JS linkage.
82 Code* BuildWithCodeStubAssemblerJS(Isolate* isolate, 82 Code* BuildWithCodeStubAssemblerJS(Isolate* isolate,
83 CodeAssemblerGenerator generator, int argc, 83 CodeAssemblerGenerator generator, int argc,
84 Code::Flags flags, const char* name) { 84 Code::Flags flags, const char* name) {
85 HandleScope scope(isolate); 85 HandleScope scope(isolate);
86 Zone zone(isolate->allocator(), ZONE_NAME); 86 Zone zone(isolate->allocator(), ZONE_NAME);
87 CodeStubAssembler assembler(isolate, &zone, argc, flags, name); 87 const int argc_with_recv = argc + 1;
88 CodeStubAssembler assembler(isolate, &zone, argc_with_recv, flags, name);
88 generator(&assembler); 89 generator(&assembler);
89 Handle<Code> code = assembler.GenerateCode(); 90 Handle<Code> code = assembler.GenerateCode();
90 PostBuildProfileAndTracing(isolate, *code, name); 91 PostBuildProfileAndTracing(isolate, *code, name);
91 return *code; 92 return *code;
92 } 93 }
93 94
94 // Builder for builtins implemented in TurboFan with CallStub linkage. 95 // Builder for builtins implemented in TurboFan with CallStub linkage.
95 Code* BuildWithCodeStubAssemblerCS(Isolate* isolate, 96 Code* BuildWithCodeStubAssemblerCS(Isolate* isolate,
96 CodeAssemblerGenerator generator, 97 CodeAssemblerGenerator generator,
97 CallDescriptors::Key interface_descriptor, 98 CallDescriptors::Key interface_descriptor,
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 // TODO(jochen): Remove this. 287 // TODO(jochen): Remove this.
287 if (responsible_context.is_null()) { 288 if (responsible_context.is_null()) {
288 return true; 289 return true;
289 } 290 }
290 if (*responsible_context == target->context()) return true; 291 if (*responsible_context == target->context()) return true;
291 return isolate->MayAccess(responsible_context, target_global_proxy); 292 return isolate->MayAccess(responsible_context, target_global_proxy);
292 } 293 }
293 294
294 } // namespace internal 295 } // namespace internal
295 } // namespace v8 296 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698