Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2439013003: [builtins] Update TFJ macro to take actual argc (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Update TFJ macro to take actual argc Up until now, the TFJ macro would take 'argc + 1' for the implicitly passed receiver. Decrease the cognitive load by making it take the explicit argc. BUG= Committed: https://crrev.com/44375382c1813ef82c266fb07012eeb1a9e0293f Cr-Commit-Position: refs/heads/master@{#40509}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -106 lines) Patch
M src/builtins/builtins.h View 1 13 chunks +105 lines, -105 lines 0 comments Download
M src/builtins/builtins.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
jgruber
4 years, 2 months ago (2016-10-21 11:03:16 UTC) #4
Yang
4 years, 2 months ago (2016-10-21 13:06:55 UTC) #7
Yang
On 2016/10/21 13:06:55, Yang wrote: lgtm.
4 years, 2 months ago (2016-10-21 13:07:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439013003/20001
4 years, 2 months ago (2016-10-21 13:14:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 13:47:17 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44375382c1813ef82c266fb07012eeb1a9e0293f
Cr-Commit-Position: refs/heads/master@{#40509}

Powered by Google App Engine
This is Rietveld 408576698