Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2438993002: WebRTC: Make WebRTC's Test more similar to Chromium's GTestTest (Closed)

Created:
4 years, 2 months ago by ehmaldonado_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Make WebRTC's Test more similar to Chromium's GTestTest BUG=657725 Committed: https://chromium.googlesource.com/chromium/tools/build/+/a842e5ed6f063f1d7b75b59891682e0650ff3703

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -88 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 4 chunks +40 lines, -36 lines 2 comments Download
M scripts/slave/recipe_modules/webrtc/steps.py View 4 chunks +20 lines, -12 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_release__swarming_.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 5 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 5 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_chromium
4 years, 2 months ago (2016-10-21 09:53:03 UTC) #3
kjellander_chromium
lgtm https://codereview.chromium.org/2438993002/diff/20001/scripts/slave/recipe_modules/webrtc/api.py File scripts/slave/recipe_modules/webrtc/api.py (right): https://codereview.chromium.org/2438993002/diff/20001/scripts/slave/recipe_modules/webrtc/api.py#newcode236 scripts/slave/recipe_modules/webrtc/api.py:236: test.pre_run(self, suffix='') https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?rcl=0&l=271 has a lot of try+except ...
4 years, 2 months ago (2016-10-21 11:04:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438993002/20001
4 years, 2 months ago (2016-10-21 13:08:12 UTC) #6
ehmaldonado_chromium
https://codereview.chromium.org/2438993002/diff/20001/scripts/slave/recipe_modules/webrtc/api.py File scripts/slave/recipe_modules/webrtc/api.py (right): https://codereview.chromium.org/2438993002/diff/20001/scripts/slave/recipe_modules/webrtc/api.py#newcode236 scripts/slave/recipe_modules/webrtc/api.py:236: test.pre_run(self, suffix='') On 2016/10/21 11:04:07, kjellander_chromium wrote: > https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?rcl=0&l=271 ...
4 years, 2 months ago (2016-10-21 13:12:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438993002/20001
4 years, 2 months ago (2016-10-21 13:16:21 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:27:31 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/a842e5ed6f063f1d7b75...

Powered by Google App Engine
This is Rietveld 408576698