Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2438913002: Use GetWebContentsGetterForRequest for compatibility with PlzNavigate (Closed)

Created:
4 years, 2 months ago by sgurun-gerrit only
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GetWebContentsGetterForRequest for compatibility with PlzNavigate After plznavigate, GetChildId/GetRenderFrameID will return -1. Instead, use GetWebContentsGetterForRequest. BUG=645983 Committed: https://crrev.com/021942e368d71dea0a25b339db6cab32b12a641a Cr-Commit-Position: refs/heads/master@{#426809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 4 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sgurun-gerrit only
On 2016/10/20 22:55:01, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:jam@chromium.org PTAL, thanks
4 years, 2 months ago (2016-10-20 22:55:10 UTC) #3
jam
lgtm
4 years, 2 months ago (2016-10-21 15:51:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438913002/1
4 years, 2 months ago (2016-10-21 15:58:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 16:38:32 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:05:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/021942e368d71dea0a25b339db6cab32b12a641a
Cr-Commit-Position: refs/heads/master@{#426809}

Powered by Google App Engine
This is Rietveld 408576698