Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2438893004: Revert of Make ChromeVox Next the default ChromeVox experience (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, achuith+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ChromeVox Next the default ChromeVox experience (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/2410773003/ ) Reason for revert: Causing many interactive_ui_tests failures, see e.g. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19184 Original issue's description: > Make ChromeVox Next the default ChromeVox experience > > - removes obsolete key configuration code from options; this leaves options as a simple, clean list of documentable settings > - change the tutorial url to point to the Next tutorial > > Pending/Optional > - change the update notification to point to a release note (rather than the tutorial) > > BUG=613255, 618097 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=dmazzoni@chromium.org,achuith@chromium.org,dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613255, 618097 Committed: https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5 Cr-Commit-Position: refs/heads/master@{#426685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -71 lines) Patch
M chrome/browser/chromeos/accessibility/speech_monitor.cc View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 11 chunks +144 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 5 chunks +208 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
Created Revert of Make ChromeVox Next the default ChromeVox experience
4 years, 2 months ago (2016-10-21 01:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438893004/1
4 years, 2 months ago (2016-10-21 01:53:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 01:54:15 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:25:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5
Cr-Commit-Position: refs/heads/master@{#426685}

Powered by Google App Engine
This is Rietveld 408576698