Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2438873002: DevTools: Fix scrolling of timeline flamechart (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix scrolling of timeline flamechart BUG=657707 Committed: https://crrev.com/2a5ba07e398d2fb5bf89258f212729530f840901 Cr-Commit-Position: refs/heads/master@{#426721}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -42 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js View 1 7 chunks +16 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 8 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alph
4 years, 2 months ago (2016-10-20 21:19:15 UTC) #2
caseq
https://codereview.chromium.org/2438873002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js (right): https://codereview.chromium.org/2438873002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js#newcode16 third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js:16: /** @private */ let's not use it on all ...
4 years, 2 months ago (2016-10-20 21:33:52 UTC) #3
alph
ptal https://codereview.chromium.org/2438873002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js (right): https://codereview.chromium.org/2438873002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js#newcode16 third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js:16: /** @private */ On 2016/10/20 21:33:51, caseq wrote: ...
4 years, 2 months ago (2016-10-20 22:59:38 UTC) #4
caseq
lgtm
4 years, 2 months ago (2016-10-20 23:06:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438873002/20001
4 years, 2 months ago (2016-10-20 23:12:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 03:51:23 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:27:17 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2a5ba07e398d2fb5bf89258f212729530f840901
Cr-Commit-Position: refs/heads/master@{#426721}

Powered by Google App Engine
This is Rietveld 408576698