Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2438833002: Change about flag for doc.write to a tri-state so it can be disabled. (Closed)

Created:
4 years, 2 months ago by shivanisha
Modified:
4 years, 2 months ago
Reviewers:
Bryan McQuade
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Change about flag for doc.write to a tri-state so it can be disabled. (cherry picked from commit 5d89eaae02f5814565f088348a6a93d48c4e9838) BUG=635743 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
shivanisha
4 years, 2 months ago (2016-10-20 19:59:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438833002/1
4 years, 2 months ago (2016-10-20 19:59:35 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-20 19:59:40 UTC) #7
Bryan McQuade
lgtm
4 years, 2 months ago (2016-10-20 20:01:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438833002/1
4 years, 2 months ago (2016-10-20 20:02:27 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 2 months ago (2016-10-20 20:02:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438833002/1
4 years, 2 months ago (2016-10-20 20:04:42 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 20:05:53 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698