Fix max preferred width for LayoutText when break-all

Fix max preferred width for LayoutText when break-all

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".

BUG=655590
Committed: https://crrev.com/715e724f5eb62b3517f093cadf5716e0fb3040ea
Cr-Commit-Position: refs/heads/master@{#426946}

[kojii, 2016-10-21 13:11:25]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 13:11:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-10-21 13:22:31]

Description was changed from

==========
break-all

BUG=
==========

to

==========
Fix max preferred width for LayoutText when break-all

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".
==========

[kojii, 2016-10-21 13:22:57]

Description was changed from

==========
Fix max preferred width for LayoutText when break-all

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".
==========

to

==========
Fix max preferred width for LayoutText when break-all

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".

BUG=655590
==========

[kojii, 2016-10-21 13:28:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 13:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-10-21 13:29:05]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-21 15:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 15:09:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-10-21 17:23:27]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:24:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-10-21 17:24:25]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-10-21 17:24:26]

PTAL.

[eae, 2016-10-21 17:31:17]

This is great, thank you!

[commit-bot: I haz the power, 2016-10-21 19:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 19:25:52]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)

[eae, 2016-10-21 22:40:26]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:40:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:40:59]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[eae, 2016-10-21 23:00:04]

I forgot to say the magic word, my bad

LGTM

[eae, 2016-10-21 23:00:25]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:01:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:36:07]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-22 01:38:30]

Description was changed from

==========
Fix max preferred width for LayoutText when break-all

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".

BUG=655590
==========

to

==========
Fix max preferred width for LayoutText when break-all

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".

BUG=655590

Committed: https://crrev.com/715e724f5eb62b3517f093cadf5716e0fb3040ea
Cr-Commit-Position: refs/heads/master@{#426946}
==========

[commit-bot: I haz the power, 2016-10-22 01:38:31]

Patchset 2 (id:??) landed as
https://crrev.com/715e724f5eb62b3517f093cadf5716e0fb3040ea
Cr-Commit-Position: refs/heads/master@{#426946}