Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2438653003: [modules] Fix bugs in assignments to exported variables. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 1 month ago
Reviewers:
adamk, mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Fix bugs in assignments to exported variables. - Add hole check if needed. - Preserve the accumulator so that the result is the rhs. R=adamk@chromium.org BUG=v8:1569, v8:5547 Committed: https://crrev.com/cadfe092a25fd052294a45a2c5aabe34b475f534 Cr-Commit-Position: refs/heads/master@{#40510}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M test/mjsunit/modules-init3.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/modules-skip-init3.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
neis
4 years, 2 months ago (2016-10-20 17:23:56 UTC) #1
adamk
lgtm (though we'll need an interpreter OWNER) Please mention the return value fix in the ...
4 years, 2 months ago (2016-10-20 17:30:16 UTC) #2
neis
On 2016/10/20 17:30:16, adamk wrote: > lgtm (though we'll need an interpreter OWNER) > > ...
4 years, 2 months ago (2016-10-21 10:04:16 UTC) #5
adamk
-ross, +mythri
4 years, 2 months ago (2016-10-21 13:28:31 UTC) #7
mythria
lgtm.
4 years, 2 months ago (2016-10-21 13:51:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438653003/20001
4 years, 2 months ago (2016-10-21 13:52:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 14:24:05 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cadfe092a25fd052294a45a2c5aabe34b475f534
Cr-Commit-Position: refs/heads/master@{#40510}

Powered by Google App Engine
This is Rietveld 408576698