Support serializable DOMFileSystem on the V8-based structured clone path.

Support serializable DOMFileSystem on the V8-based structured clone path.

This one is a little quirky (most filesystems aren't serializable), and since
the existing serializer already relied on an enum not changing, I've added
a warning comment to that enum, in the hopes of avoiding breaking it in the
future.

BUG=148757
Committed: https://crrev.com/3cc75304de279f96456c803e26ca0624226151fb
Cr-Commit-Position: refs/heads/master@{#426478}

[jbroman, 2016-10-19 22:06:46]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 22:07:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:43:35]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-10-20 14:26:43]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-10-20 14:51:57]

LGTM

https://codereview.chromium.org/2438653002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/FileSystemType.h (right):

https://codereview.chromium.org/2438653002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/FileSystemType.h:40: // the previous version
of this enum.

Nice catch!

[jbroman, 2016-10-20 14:53:10]

The CQ bit was checked by jbroman@chromium.org

[haraken, 2016-10-20 14:53:17]

On 2016/10/20 14:51:57, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/2438653002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/FileSystemType.h (right):
> 
>
https://codereview.chromium.org/2438653002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/FileSystemType.h:40: // the previous
version
> of this enum.
> 
> Nice catch!

Is this the only place we're serializing an enum? This looks like a general
issue to enum values.

[commit-bot: I haz the power, 2016-10-20 14:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 15:05:25]

Committed patchset #1 (id:1)

[jbroman, 2016-10-20 15:05:36]

On 2016/10/20 at 14:53:17, haraken wrote:
> On 2016/10/20 14:51:57, haraken wrote:
> > LGTM
> > 
> >
https://codereview.chromium.org/2438653002/diff/1/third_party/WebKit/Source/p...
> > File third_party/WebKit/Source/platform/FileSystemType.h (right):
> > 
> >
https://codereview.chromium.org/2438653002/diff/1/third_party/WebKit/Source/p...
> > third_party/WebKit/Source/platform/FileSystemType.h:40: // the previous
version
> > of this enum.
> > 
> > Nice catch!
> 
> Is this the only place we're serializing an enum? This looks like a general
issue to enum values.

CryptoKey has separate enums for serialization and switch statements to convert
between them (which should help). V8 RegExp flags are also serialized directly
(I think there's a comment there as well).

[commit-bot: I haz the power, 2016-10-21 13:18:22]

Description was changed from

==========
Support serializable DOMFileSystem on the V8-based structured clone path.

This one is a little quirky (most filesystems aren't serializable), and since
the existing serializer already relied on an enum not changing, I've added
a warning comment to that enum, in the hopes of avoiding breaking it in the
future.

BUG=148757
==========

to

==========
Support serializable DOMFileSystem on the V8-based structured clone path.

This one is a little quirky (most filesystems aren't serializable), and since
the existing serializer already relied on an enum not changing, I've added
a warning comment to that enum, in the hopes of avoiding breaking it in the
future.

BUG=148757

Committed: https://crrev.com/3cc75304de279f96456c803e26ca0624226151fb
Cr-Commit-Position: refs/heads/master@{#426478}
==========

[commit-bot: I haz the power, 2016-10-21 13:18:23]

Patchset 1 (id:??) landed as
https://crrev.com/3cc75304de279f96456c803e26ca0624226151fb
Cr-Commit-Position: refs/heads/master@{#426478}