Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2438643005: Replace SkAutoTUnref with sk_sp. (Closed)

Created:
4 years, 2 months ago by bungeman-chromium
Modified:
4 years, 2 months ago
Reviewers:
drott, f(malita)
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SkAutoTUnref with sk_sp. Skia is interested in replacing all uses of SkAutoTUnref with sk_sp and then hiding SkAutoTUnref with the intention of removing it in the future. This appears to be the only use of this class in Chromium outside of Skia itself. Committed: https://crrev.com/ebc51c8593e97b4e68d18fe5130fffbd56bd26c2 Cr-Commit-Position: refs/heads/master@{#426864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
bungeman-chromium
4 years, 2 months ago (2016-10-21 18:30:34 UTC) #5
bungeman-chromium
4 years, 2 months ago (2016-10-21 18:31:05 UTC) #7
f(malita)
lgtm
4 years, 2 months ago (2016-10-21 18:34:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438643005/1
4 years, 2 months ago (2016-10-21 18:36:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 19:36:56 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 19:45:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebc51c8593e97b4e68d18fe5130fffbd56bd26c2
Cr-Commit-Position: refs/heads/master@{#426864}

Powered by Google App Engine
This is Rietveld 408576698