MD Settings: Migrate cookies iron-dropdown to settings-action-menu.

MD Settings: Migrate cookies iron-dropdown to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d24c6802d3ac1c6d62b29e6a3fa685a350f694e3
Cr-Commit-Position: refs/heads/master@{#426712}

[dpapad, 2016-10-20 21:09:34]

Description was changed from

==========
MD Settings: Migrate cookies iron-dropdown to settings-action-menu.

BUG=639718
==========

to

==========
MD Settings: Migrate cookies iron-dropdown to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-20 21:13:30]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 21:14:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 22:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:09:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2016-10-20 22:59:18]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:59:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-20 23:00:56]

Patchset #3 (id:40001) has been deleted

[dpapad, 2016-10-20 23:08:40]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:09:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-20 23:26:22]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-10-20 23:26:22]

Screenshot at http://imgur.com/a/pP6WH.

[dschuyler, 2016-10-21 00:41:08]

LGTM with @param. Thanks for converting this!

https://codereview.chromium.org/2438643004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2438643004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.js:496: /** @private
*/
@param for e

[dpapad, 2016-10-21 00:56:06]

Thanks for the quick review.

https://codereview.chromium.org/2438643004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2438643004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.js:496: /** @private
*/
On 2016/10/21 at 00:41:08, dschuyler wrote:
> @param for e

Done. It is unfortunate that we are using non-standard events, since |model| is
not a property of the Event class, which makes this code full of type casts and
decreases readability. Not sure how to fix this at this point, but I would be
happy to clean up if/when we have a better solution.

[dpapad, 2016-10-21 01:18:22]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-21 01:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2438643004/#ps80001
(title: "Nit.")

[commit-bot: I haz the power, 2016-10-21 01:19:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:40:31]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:26:52]

Description was changed from

==========
MD Settings: Migrate cookies iron-dropdown to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Migrate cookies iron-dropdown to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d24c6802d3ac1c6d62b29e6a3fa685a350f694e3
Cr-Commit-Position: refs/heads/master@{#426712}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:53]

Patchset 4 (id:??) landed as
https://crrev.com/d24c6802d3ac1c6d62b29e6a3fa685a350f694e3
Cr-Commit-Position: refs/heads/master@{#426712}