Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2438613007: When a QUIC PublicReset packet is received, Log the client IP from both the SHLO and the PublicReset (Closed)

Created:
4 years, 2 months ago by Ryan Hamilton
Modified:
4 years, 2 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When a QUIC PublicReset packet is received, Log the client IP from both the SHLO and the PublicReset packet. BUG= Committed: https://crrev.com/e077a44877555fac78ec942cc20f5f11a9a3dc2f Cr-Commit-Position: refs/heads/master@{#426899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M net/quic/chromium/quic_connection_logger.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Ryan Hamilton
4 years, 2 months ago (2016-10-21 17:52:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438613007/1
4 years, 2 months ago (2016-10-21 17:52:59 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-21 17:53:01 UTC) #6
Zhongyi Shi
lgtm
4 years, 2 months ago (2016-10-21 18:41:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438613007/1
4 years, 2 months ago (2016-10-21 21:24:31 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 21:48:43 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 21:52:10 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e077a44877555fac78ec942cc20f5f11a9a3dc2f
Cr-Commit-Position: refs/heads/master@{#426899}

Powered by Google App Engine
This is Rietveld 408576698