Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2438613004: Remove first-line-in-cell strut subtraction workaround. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
rhogan, dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove first-line-in-cell strut subtraction workaround. This is no longer needed. In fact, it was causing some trouble. BUG=534751 Committed: https://crrev.com/b681a78078f7a1460a5dab4e6c6fa7416f122b13 Cr-Commit-Position: refs/heads/master@{#426435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
A + third_party/WebKit/LayoutTests/fragmentation/table-row-dimensions-break-freely.html View 2 chunks +3 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fragmentation/table-row-dimensions-break-freely-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-19 21:26:51 UTC) #4
eae
Yay, LGTM!
4 years, 2 months ago (2016-10-19 21:54:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438613004/1
4 years, 2 months ago (2016-10-20 09:11:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 09:20:15 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b681a78078f7a1460a5dab4e6c6fa7416f122b13
Cr-Commit-Position: refs/heads/master@{#426435}

Powered by Google App Engine
This is Rietveld 408576698