Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/fuzzer/wasm-code.cc

Issue 2438603003: [wasm] Track in the interpreter if a NaN could have been produced. (Closed)
Patch Set: Fixed nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/common/wasm/wasm-module-runner.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 ErrorThrower interpreter_thrower(i_isolate, "Interpreter"); 57 ErrorThrower interpreter_thrower(i_isolate, "Interpreter");
58 std::unique_ptr<const WasmModule> module(testing::DecodeWasmModuleForTesting( 58 std::unique_ptr<const WasmModule> module(testing::DecodeWasmModuleForTesting(
59 i_isolate, &interpreter_thrower, buffer.begin(), buffer.end(), 59 i_isolate, &interpreter_thrower, buffer.begin(), buffer.end(),
60 v8::internal::wasm::ModuleOrigin::kWasmOrigin)); 60 v8::internal::wasm::ModuleOrigin::kWasmOrigin));
61 61
62 if (module == nullptr) { 62 if (module == nullptr) {
63 return 0; 63 return 0;
64 } 64 }
65 int32_t result_interpreted; 65 int32_t result_interpreted;
66 bool possible_nondeterminism = false;
66 { 67 {
67 WasmVal args[] = {WasmVal(1), WasmVal(2), WasmVal(3)}; 68 WasmVal args[] = {WasmVal(1), WasmVal(2), WasmVal(3)};
68 result_interpreted = testing::InterpretWasmModule( 69 result_interpreted = testing::InterpretWasmModule(
69 i_isolate, &interpreter_thrower, module.get(), 0, args); 70 i_isolate, &interpreter_thrower, module.get(), 0, args,
71 &possible_nondeterminism);
70 } 72 }
71 73
72 ErrorThrower compiler_thrower(i_isolate, "Compiler"); 74 ErrorThrower compiler_thrower(i_isolate, "Compiler");
73 v8::internal::Handle<v8::internal::JSObject> instance = 75 v8::internal::Handle<v8::internal::JSObject> instance =
74 testing::InstantiateModuleForTesting(i_isolate, &compiler_thrower, 76 testing::InstantiateModuleForTesting(i_isolate, &compiler_thrower,
75 module.get()); 77 module.get());
76 78
77 if (!interpreter_thrower.error()) { 79 if (!interpreter_thrower.error()) {
78 CHECK(!instance.is_null()); 80 CHECK(!instance.is_null());
79 } else { 81 } else {
80 return 0; 82 return 0;
81 } 83 }
82 int32_t result_compiled; 84 int32_t result_compiled;
83 { 85 {
84 v8::internal::Handle<v8::internal::Object> arguments[] = { 86 v8::internal::Handle<v8::internal::Object> arguments[] = {
85 v8::internal::handle(v8::internal::Smi::FromInt(1), i_isolate), 87 v8::internal::handle(v8::internal::Smi::FromInt(1), i_isolate),
86 v8::internal::handle(v8::internal::Smi::FromInt(2), i_isolate), 88 v8::internal::handle(v8::internal::Smi::FromInt(2), i_isolate),
87 v8::internal::handle(v8::internal::Smi::FromInt(3), i_isolate)}; 89 v8::internal::handle(v8::internal::Smi::FromInt(3), i_isolate)};
88 result_compiled = testing::CallWasmFunctionForTesting( 90 result_compiled = testing::CallWasmFunctionForTesting(
89 i_isolate, instance, &compiler_thrower, "main", arraysize(arguments), 91 i_isolate, instance, &compiler_thrower, "main", arraysize(arguments),
90 arguments, v8::internal::wasm::ModuleOrigin::kWasmOrigin); 92 arguments, v8::internal::wasm::ModuleOrigin::kWasmOrigin);
91 } 93 }
92 if (result_interpreted == 0xdeadbeef) { 94 if (result_interpreted == 0xdeadbeef) {
93 CHECK(i_isolate->has_pending_exception()); 95 CHECK(i_isolate->has_pending_exception());
94 i_isolate->clear_pending_exception(); 96 i_isolate->clear_pending_exception();
95 } else { 97 } else {
96 if (result_interpreted != result_compiled) { 98 // The WebAssembly spec allows the sign bit of NaN to be non-deterministic.
99 // This sign bit may cause result_interpreted to be different than
100 // result_compiled. Therefore we do not check the equality of the results
101 // if the execution may have produced a NaN at some point.
102 if (!possible_nondeterminism && (result_interpreted != result_compiled)) {
97 V8_Fatal(__FILE__, __LINE__, "WasmCodeFuzzerHash=%x", 103 V8_Fatal(__FILE__, __LINE__, "WasmCodeFuzzerHash=%x",
98 v8::internal::StringHasher::HashSequentialString( 104 v8::internal::StringHasher::HashSequentialString(
99 data, static_cast<int>(size), WASM_CODE_FUZZER_HASH_SEED)); 105 data, static_cast<int>(size), WASM_CODE_FUZZER_HASH_SEED));
100 } 106 }
101 } 107 }
102 return 0; 108 return 0;
103 } 109 }
OLDNEW
« no previous file with comments | « test/common/wasm/wasm-module-runner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698