Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2438593003: [wasm] Remove incorrect assembler check. (Closed)

Created:
4 years, 2 months ago by gdeepti
Modified:
4 years, 1 month ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove incorrect assembler check. BUG=chromium:644670 R=ahaas@chromium.org, titzer@chromium.org Committed: https://crrev.com/e936685b0d15a246a9ce1ef64e0e7f8c01ca186e Cr-Commit-Position: refs/heads/master@{#40451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/assembler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/wasm/grow-memory.js View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
gdeepti
Attempting to reland this change - https://codereview.chromium.org/2376153003/ Failure that was on the bots is not ...
4 years, 2 months ago (2016-10-20 04:15:25 UTC) #5
ahaas
lgtm
4 years, 2 months ago (2016-10-20 07:32:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438593003/1
4 years, 2 months ago (2016-10-20 07:33:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 07:39:03 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e936685b0d15a246a9ce1ef64e0e7f8c01ca186e
Cr-Commit-Position: refs/heads/master@{#40451}

Powered by Google App Engine
This is Rietveld 408576698