[webcrypto] Reject failed operations with a DOMException rather than null.

[webcrypto] Reject failed operations with a DOMException rather than null.

This corresponds with the WebCrypto spec update:
https://dvcs.w3.org/hg/webcrypto-api/rev/64993be45f9f

BUG=245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172812

[abarth-chromium, 2014-04-19 16:33:20]

lgtm

https://codereview.chromium.org/243853004/diff/1/Source/modules/crypto/Normal...
File Source/modules/crypto/NormalizeAlgorithm.cpp (right):

https://codereview.chromium.org/243853004/diff/1/Source/modules/crypto/Normal...
Source/modules/crypto/NormalizeAlgorithm.cpp:768: }
Can we make this static data rather than code?

[eroman, 2014-04-21 20:39:09]

https://codereview.chromium.org/243853004/diff/1/Source/modules/crypto/Normal...
File Source/modules/crypto/NormalizeAlgorithm.cpp (right):

https://codereview.chromium.org/243853004/diff/1/Source/modules/crypto/Normal...
Source/modules/crypto/NormalizeAlgorithm.cpp:768: }
On 2014/04/19 16:33:20, abarth wrote:
> Can we make this static data rather than code?

Sure, what kind of static data structure were you thinking?

My sense was that a switch statement on consecutive integers like this will
compile down to a flat data table as well. Using a switch is convenient since it
gives compile time error if not each case is handled.

[abarth-chromium, 2014-04-21 21:02:14]

On 2014/04/21 20:39:09, eroman wrote:
>
https://codereview.chromium.org/243853004/diff/1/Source/modules/crypto/Normal...
> File Source/modules/crypto/NormalizeAlgorithm.cpp (right):
> 
>
https://codereview.chromium.org/243853004/diff/1/Source/modules/crypto/Normal...
> Source/modules/crypto/NormalizeAlgorithm.cpp:768: }
> On 2014/04/19 16:33:20, abarth wrote:
> > Can we make this static data rather than code?
> 
> Sure, what kind of static data structure were you thinking?

Oh, I was just thinking of a static array with the data.

> My sense was that a switch statement on consecutive integers like this will
> compile down to a flat data table as well. Using a switch is convenient since
it
> gives compile time error if not each case is handled.

You can get that with a static array too:

enum Foo { A, B, C, FooLast = C }

static const char* data[FooLast + 1] = { "a", "b", "c" };
const char* toData(Foo foo) { return data[foo]; }

Anyway, this certainly isn't a big deal one way or another.  I was just
wondering if the data-based version used less binary for the same effect. 
Either is completely fine with me.

[eroman, 2014-04-28 19:55:10]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-28 19:55:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/243853004/20001

[eroman, 2014-04-28 20:04:18]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:05:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/243853004/40001

[eroman, 2014-04-28 20:21:03]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:21:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/243853004/60001

[commit-bot: I haz the power, 2014-04-28 22:28:03]

Change committed as 172812