Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.cc

Issue 2438513003: When parsing cookie expiration times, saturate out of range dates (Closed)
Patch Set: Response to comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/canonical_cookie.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/web_request/web_request_api_helpers.cc
diff --git a/extensions/browser/api/web_request/web_request_api_helpers.cc b/extensions/browser/api/web_request/web_request_api_helpers.cc
index 990570b71abd3f04ef512915ed47f1487e7c09ce..a7e88490401bff6fcb15bf081db787466040766d 100644
--- a/extensions/browser/api/web_request/web_request_api_helpers.cc
+++ b/extensions/browser/api/web_request/web_request_api_helpers.cc
@@ -115,8 +115,10 @@ bool ParseCookieLifetime(net::ParsedCookie* cookie,
}
Time parsed_expiry_time;
- if (cookie->HasExpires())
- parsed_expiry_time = net::cookie_util::ParseCookieTime(cookie->Expires());
+ if (cookie->HasExpires()) {
+ parsed_expiry_time =
+ net::cookie_util::ParseCookieExpirationTime(cookie->Expires());
+ }
if (!parsed_expiry_time.is_null()) {
*seconds_till_expiry =
« no previous file with comments | « no previous file | net/cookies/canonical_cookie.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698