Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: net/cookies/cookie_util.h

Issue 2438513003: When parsing cookie expiration times, saturate out of range dates (Closed)
Patch Set: Clean up comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cookies/cookie_monster_store_test.cc ('k') | net/cookies/cookie_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_COOKIES_COOKIE_UTIL_H_ 5 #ifndef NET_COOKIES_COOKIE_UTIL_H_
6 #define NET_COOKIES_COOKIE_UTIL_H_ 6 #define NET_COOKIES_COOKIE_UTIL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 19 matching lines...) Expand all
30 // -host cookie domain (ex: "google.com") 30 // -host cookie domain (ex: "google.com")
31 // -domain cookie domain (ex: ".google.com") 31 // -domain cookie domain (ex: ".google.com")
32 NET_EXPORT bool GetCookieDomainWithString(const GURL& url, 32 NET_EXPORT bool GetCookieDomainWithString(const GURL& url,
33 const std::string& domain_string, 33 const std::string& domain_string,
34 std::string* result); 34 std::string* result);
35 35
36 // Returns true if a domain string represents a host-only cookie, 36 // Returns true if a domain string represents a host-only cookie,
37 // i.e. it doesn't begin with a leading '.' character. 37 // i.e. it doesn't begin with a leading '.' character.
38 NET_EXPORT bool DomainIsHostOnly(const std::string& domain_string); 38 NET_EXPORT bool DomainIsHostOnly(const std::string& domain_string);
39 39
40 // Parses the string with the cookie time (very forgivingly). 40 // Parses the string with the cookie expiration time (very forgivingly).
41 NET_EXPORT base::Time ParseCookieTime(const std::string& time_string); 41 // Returns the "null" time on failure.
42 //
43 // If the expiration date is outside the platform-specific range supported by
44 // Time::FromUTCExplodeded(), then this will return the min/max non-null
eroman 2016/10/20 16:00:22 Can you instead explicitly say Time(1) and Time::M
45 // base::Time() value.
46 NET_EXPORT base::Time ParseCookieExpirationTime(const std::string& time_string);
42 47
43 // Convenience for converting a cookie origin (domain and https pair) to a URL. 48 // Convenience for converting a cookie origin (domain and https pair) to a URL.
44 NET_EXPORT GURL CookieOriginToURL(const std::string& domain, bool is_https); 49 NET_EXPORT GURL CookieOriginToURL(const std::string& domain, bool is_https);
45 50
46 // A ParsedRequestCookie consists of the key and value of the cookie. 51 // A ParsedRequestCookie consists of the key and value of the cookie.
47 typedef std::pair<base::StringPiece, base::StringPiece> ParsedRequestCookie; 52 typedef std::pair<base::StringPiece, base::StringPiece> ParsedRequestCookie;
48 typedef std::vector<ParsedRequestCookie> ParsedRequestCookies; 53 typedef std::vector<ParsedRequestCookie> ParsedRequestCookies;
49 54
50 // Assumes that |header_value| is the cookie header value of a HTTP Request 55 // Assumes that |header_value| is the cookie header value of a HTTP Request
51 // following the cookie-string schema of RFC 6265, section 4.2.1, and returns 56 // following the cookie-string schema of RFC 6265, section 4.2.1, and returns
52 // cookie name/value pairs. If cookie values are presented in double quotes, 57 // cookie name/value pairs. If cookie values are presented in double quotes,
53 // these will appear in |parsed_cookies| as well. Assumes that the cookie 58 // these will appear in |parsed_cookies| as well. Assumes that the cookie
54 // header is written by Chromium and therefore well-formed. 59 // header is written by Chromium and therefore well-formed.
55 NET_EXPORT void ParseRequestCookieLine(const std::string& header_value, 60 NET_EXPORT void ParseRequestCookieLine(const std::string& header_value,
56 ParsedRequestCookies* parsed_cookies); 61 ParsedRequestCookies* parsed_cookies);
57 62
58 // Writes all cookies of |parsed_cookies| into a HTTP Request header value 63 // Writes all cookies of |parsed_cookies| into a HTTP Request header value
59 // that belongs to the "Cookie" header. The entries of |parsed_cookies| must 64 // that belongs to the "Cookie" header. The entries of |parsed_cookies| must
60 // already be appropriately escaped. 65 // already be appropriately escaped.
61 NET_EXPORT std::string SerializeRequestCookieLine( 66 NET_EXPORT std::string SerializeRequestCookieLine(
62 const ParsedRequestCookies& parsed_cookies); 67 const ParsedRequestCookies& parsed_cookies);
63 68
64 } // namespace cookie_util 69 } // namespace cookie_util
65 } // namespace net 70 } // namespace net
66 71
67 #endif // NET_COOKIES_COOKIE_UTIL_H_ 72 #endif // NET_COOKIES_COOKIE_UTIL_H_
OLDNEW
« no previous file with comments | « net/cookies/cookie_monster_store_test.cc ('k') | net/cookies/cookie_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698