Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2438513002: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/supervised_user (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org, markusheintz_, jam, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FOR_EACH_OBSERVER macro usage in chrome/browser/supervised_user Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713 Cr-Commit-Position: refs/heads/master@{#426307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -41 lines) Patch
M chrome/browser/content_settings/tab_specific_content_settings.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_installer.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Eric Willigers
4 years, 2 months ago (2016-10-19 11:45:26 UTC) #2
Bernhard Bauer
LGTM, thanks!
4 years, 2 months ago (2016-10-19 11:57:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438513002/1
4 years, 2 months ago (2016-10-19 20:12:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 22:22:24 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:12:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713
Cr-Commit-Position: refs/heads/master@{#426307}

Powered by Google App Engine
This is Rietveld 408576698