Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: components/offline_pages/background/mark_attempt_started_task.h

Issue 2438503003: [Offline pages] Add MarkAttemptAbortedTask to Request Queue (Closed)
Patch Set: Addressing feedback -- adding comments and documentation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/mark_attempt_started_task.h
diff --git a/components/offline_pages/background/mark_attempt_started_task.h b/components/offline_pages/background/mark_attempt_started_task.h
index c01df652c6396a49db39e27cd7990c0616a0e333..8afaef8e76f05f18008b42f7ab42af67f1a26a94 100644
--- a/components/offline_pages/background/mark_attempt_started_task.h
+++ b/components/offline_pages/background/mark_attempt_started_task.h
@@ -7,44 +7,22 @@
#include <stdint.h>
-#include <memory>
-#include <unordered_set>
-#include <vector>
-
-#include "base/memory/weak_ptr.h"
#include "components/offline_pages/background/request_queue_store.h"
-#include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/background/update_request_task.h"
#include "components/offline_pages/core/task.h"
namespace offline_pages {
-class MarkAttemptStartedTask : public Task {
+class MarkAttemptStartedTask : public UpdateRequestTask {
public:
MarkAttemptStartedTask(RequestQueueStore* store,
int64_t request_id,
const RequestQueueStore::UpdateCallback& callback);
~MarkAttemptStartedTask() override;
- // TaskQueue::Task implementation.
- void Run() override;
-
- private:
- // Step 1. Reading the requests.
- void ReadRequest();
- // Step 2. Verifies item exists, marks started and saves.
- void MarkAttemptStarted(std::unique_ptr<UpdateRequestsResult> result);
- // Step 3. Completes once update is done.
- void CompleteWithResult(std::unique_ptr<UpdateRequestsResult> result);
-
- // Store that this task updates. Not owned.
- RequestQueueStore* store_;
- // Request ID of the request to be started.
- int64_t request_id_;
- // Callback to complete the task.
- RequestQueueStore::UpdateCallback callback_;
-
- base::WeakPtrFactory<MarkAttemptStartedTask> weak_ptr_factory_;
- DISALLOW_COPY_AND_ASSIGN(MarkAttemptStartedTask);
+ protected:
+ // UpdateRequestTask implementation:
+ void UpdateRequestImpl(std::unique_ptr<UpdateRequestsResult> result) override;
};
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698