Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2438483002:
Add tests for CodeStubAssembler::ToString (Closed)
|
Created:
4 years, 2 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 1 month ago Reviewers:
danno CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAdd tests for CodeStubAssembler::ToString
R=danno@chromium.org
Committed: https://crrev.com/f4be20cbdac1ea41e4e5f012ca9d031dd7a3ac35
Cr-Commit-Position: refs/heads/master@{#40437}
Patch Set 1 #Patch Set 2 : updates #Patch Set 3 : updates #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11091)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add CodeStubAssembler::ToString BUG= ========== to ========== Add tests for CodeStubAssembler::ToString R=danno@chromium.org ==========
jochen@chromium.org changed reviewers: + danno@chromium.org
ptal
lgtm
The CQ bit was unchecked by jochen@chromium.org
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jochen@chromium.org
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danno@chromium.org Link to the patchset: https://codereview.chromium.org/2438483002/#ps40001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add tests for CodeStubAssembler::ToString R=danno@chromium.org ========== to ========== Add tests for CodeStubAssembler::ToString R=danno@chromium.org Committed: https://crrev.com/f4be20cbdac1ea41e4e5f012ca9d031dd7a3ac35 Cr-Commit-Position: refs/heads/master@{#40437} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f4be20cbdac1ea41e4e5f012ca9d031dd7a3ac35 Cr-Commit-Position: refs/heads/master@{#40437} |
