Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2438343002: [Payments] Don't suggest profiles with no street address in PR. (Closed)

Created:
4 years, 2 months ago by sebsg
Modified:
4 years, 2 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Don't suggest profiles with no street address in PR. BUG=658346 Committed: https://crrev.com/d6efc8643cafe5e3825ae422b4a12f2197633cf7 Cr-Commit-Position: refs/heads/master@{#426890}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java View 1 4 chunks +63 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
sebsg
Hi Rouslan, could you please take a look? Thanks!
4 years, 2 months ago (2016-10-21 18:32:47 UTC) #3
please use gerrit instead
lgtm % nit https://codereview.chromium.org/2438343002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java (right): https://codereview.chromium.org/2438343002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java#newcode31 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java:31: "Marge Simpson", "Acme Inc.", "123 Main", ...
4 years, 2 months ago (2016-10-21 18:36:25 UTC) #6
sebsg
Thanks, put the names back in order and added a test. https://codereview.chromium.org/2438343002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java (right): ...
4 years, 2 months ago (2016-10-21 19:25:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438343002/60001
4 years, 2 months ago (2016-10-21 21:03:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-10-21 21:20:37 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 21:22:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6efc8643cafe5e3825ae422b4a12f2197633cf7
Cr-Commit-Position: refs/heads/master@{#426890}

Powered by Google App Engine
This is Rietveld 408576698