Non-SFI NaCl: Disallow futex call without FUTEX_PRIVATE_FLAG

components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/loader/nonsfi/nonsfi_sandbox.h"
 
 #include <errno.h>
 #include <fcntl.h>
+#include <linux/futex.h>
 #include <pthread.h>
 #include <sched.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/mman.h>
 #include <sys/prctl.h>
 #include <sys/ptrace.h>
 #include <sys/socket.h>
 #include <sys/syscall.h>
+#include <sys/time.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/files/scoped_file.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
@@ skipping 79 matching lines @@
   ASSERT_EQ(0, WEXITSTATUS(status));
 }
 
 // Then, try this in the sandbox.
 BPF_DEATH_TEST(NaClNonSfiSandboxTest, clone_for_fork,
                DEATH_MESSAGE(sandbox::GetCloneErrorMessageContentForTests()),
                nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
   DoFork();
 }
 
+BPF_TEST(NaClNonSfiSandboxTest, futex_allowed,
+         nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
+  errno = 0;
+  int v = 0;
+  struct timespec ts;
+  ts.tv_sec = 0;
+  ts.tv_nsec = 1;  // 1 nanosecond.
+  BPF_ASSERT_EQ(-1, syscall(__NR_futex, &v,
+                            FUTEX_WAIT_PRIVATE, 0, &ts, NULL, 0));
+  BPF_ASSERT_EQ(ETIMEDOUT, errno);
+}
+
+// TODO(hamaji): Disallow non-PRIVATE FUTEX_WAIT.
+BPF_TEST(NaClNonSfiSandboxTest, futex_FUTEX_WAIT_allowed,
+         nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
+  errno = 0;
+  int v = 0;
+  struct timespec ts;
+  ts.tv_sec = 0;
+  ts.tv_nsec = 1;  // 1 nanosecond.
+  BPF_ASSERT_EQ(-1, syscall(__NR_futex, &v, FUTEX_WAIT, 0, &ts, NULL, 0));
+  BPF_ASSERT_EQ(ETIMEDOUT, errno);
+}
+
+BPF_DEATH_TEST(NaClNonSfiSandboxTest, futex_FUTEX_WAKE,
+               DEATH_MESSAGE(sandbox::GetErrorMessageContentForTests()),
+               nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
+  syscall(__NR_futex, NULL, FUTEX_WAKE, 0, NULL, NULL, 0);
+}
+
 BPF_TEST(NaClNonSfiSandboxTest, prctl_SET_NAME,
          nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
   errno = 0;
   BPF_ASSERT_EQ(-1, syscall(__NR_prctl, PR_SET_NAME, "foo"));
   BPF_ASSERT_EQ(EPERM, errno);
 }
 
 BPF_DEATH_TEST(NaClNonSfiSandboxTest, prctl_SET_DUMPABLE,
                DEATH_MESSAGE(sandbox::GetPrctlErrorMessageContentForTests()),
                nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
@@ skipping 354 matching lines @@
 #if defined(__i386__) || defined(__x86_64__)
 BPF_TEST(NaClNonSfiSandboxTest, time_EPERM,
          nacl::nonsfi::NaClNonSfiBPFSandboxPolicy::EvaluateSyscallImpl) {
   errno = 0;
   BPF_ASSERT_EQ(-1, syscall(__NR_time));
   BPF_ASSERT_EQ(EPERM, errno);
 }
 #endif
 
 }  // namespace