Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2438283002: Revert of [regexp] Use consistent map checks for fast paths (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
Yang, jgruber
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Use consistent map checks for fast paths (patchset #7 id:120001 of https://chromiumcodereview.appspot.com/2434983002/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10853 Original issue's description: > [regexp] Use consistent map checks for fast paths > > These map checks were implemented for TF code already. This CL makes > sure that parts implemented in C++ follow the same logic, which is: > > An object is an unmodified regexp if: > 1) it's a receiver, > 2) its map is the initial regexp map, > 3) its prototype is a receiver, > 4) and its prototype's map is the initial prototype's initial map. > > We can now be smarter in @@replace and @@split since checking maps > (unlike the previous check of RegExp.prototype.exec) is not observable, > so we can perform fast-path checks at a time of our choosing. > > BUG=v8:5339, v8:5434, v8:5123 TBR=yangguo@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339, v8:5434, v8:5123 Committed: https://crrev.com/0b7e35ff16df021d458c85d0019ca4858d9fe487 Cr-Commit-Position: refs/heads/master@{#40499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -40 lines) Patch
M src/builtins/builtins-regexp.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/regexp/regexp-utils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/regexp/regexp-utils.cc View 1 chunk +5 lines, -16 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +23 lines, -9 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +2 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [regexp] Use consistent map checks for fast paths
4 years, 2 months ago (2016-10-21 11:14:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438283002/1
4 years, 2 months ago (2016-10-21 11:14:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 11:15:02 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:09:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b7e35ff16df021d458c85d0019ca4858d9fe487
Cr-Commit-Position: refs/heads/master@{#40499}

Powered by Google App Engine
This is Rietveld 408576698