Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2438273002: Reland Update implementation of atomics with latest Chromium version but use compiler builtin atomi… (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Update implementation of atomics with latest Chromium version but use compiler builtin atomics BUG= Committed: https://crrev.com/726becfb4982127dc1475c29d763a691f3599d16 Cr-Commit-Position: refs/heads/master@{#40496}

Patch Set 1 #

Patch Set 2 : fix memory order for release cmpxchg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -2484 lines) Patch
M BUILD.gn View 1 chunk +1 line, -9 lines 0 comments Download
M src/base/atomicops.h View 3 chunks +14 lines, -27 lines 0 comments Download
D src/base/atomicops_internals_arm64_gcc.h View 1 chunk +0 lines, -317 lines 0 comments Download
D src/base/atomicops_internals_arm_gcc.h View 1 chunk +0 lines, -304 lines 0 comments Download
M src/base/atomicops_internals_atomicword_compat.h View 2 chunks +0 lines, -10 lines 0 comments Download
D src/base/atomicops_internals_mac.h View 1 chunk +0 lines, -216 lines 0 comments Download
D src/base/atomicops_internals_mips64_gcc.h View 1 chunk +0 lines, -310 lines 0 comments Download
D src/base/atomicops_internals_mips_gcc.h View 1 chunk +0 lines, -161 lines 0 comments Download
A src/base/atomicops_internals_portable.h View 1 1 chunk +172 lines, -0 lines 0 comments Download
D src/base/atomicops_internals_ppc_gcc.h View 1 chunk +0 lines, -168 lines 0 comments Download
D src/base/atomicops_internals_s390_gcc.h View 1 chunk +0 lines, -152 lines 0 comments Download
D src/base/atomicops_internals_tsan.h View 1 chunk +0 lines, -363 lines 0 comments Download
D src/base/atomicops_internals_x86_gcc.h View 1 chunk +0 lines, -278 lines 0 comments Download
D src/base/atomicops_internals_x86_gcc.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M src/base/atomicops_internals_x86_msvc.h View 7 chunks +8 lines, -33 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -10 lines 0 comments Download
M test/cctest/test-atomicops.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Hannes Payer (out of office)
4 years, 2 months ago (2016-10-21 09:35:16 UTC) #4
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-21 09:44:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438273002/20001
4 years, 2 months ago (2016-10-21 10:00:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 10:05:36 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:09:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/726becfb4982127dc1475c29d763a691f3599d16
Cr-Commit-Position: refs/heads/master@{#40496}

Powered by Google App Engine
This is Rietveld 408576698