Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 2438163002: Remove SpdyFramerVisitorInterface::OnControlFrameHeaderData(). (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer_decoder_adapter.cc ('k') | net/spdy/spdy_no_op_visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer_test.cc
diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc
index 4c751c2124acdff2ad691e78334d68ba53cc1d64..80a165557c206e037129bee19b1876a029c4ab94 100644
--- a/net/spdy/spdy_framer_test.cc
+++ b/net/spdy/spdy_framer_test.cc
@@ -165,13 +165,6 @@ class SpdyFramerTestUtil {
LOG(FATAL);
}
- bool OnControlFrameHeaderData(SpdyStreamId stream_id,
- const char* header_data,
- size_t len) override {
- LOG(FATAL);
- return true;
- }
-
void OnRstStream(SpdyStreamId stream_id,
SpdyRstStreamStatus status) override {
LOG(FATAL);
@@ -391,31 +384,6 @@ class TestSpdyVisitor : public SpdyFramerVisitorInterface,
}
}
- bool OnControlFrameHeaderData(SpdyStreamId stream_id,
- const char* header_data,
- size_t len) override {
- VLOG(1) << "OnControlFrameHeaderData(" << stream_id << ", data, " << len
- << ")";
- ++control_frame_header_data_count_;
- CHECK_EQ(header_stream_id_, stream_id);
- if (len == 0) {
- ++zero_length_control_frame_header_data_count_;
- // Indicates end-of-header-block.
- headers_.clear();
- CHECK(header_buffer_valid_);
- return framer_.ParseHeaderBlockInBuffer(header_buffer_.get(),
- header_buffer_length_, &headers_);
- }
- const size_t available = header_buffer_size_ - header_buffer_length_;
- if (len > available) {
- header_buffer_valid_ = false;
- return false;
- }
- memcpy(header_buffer_.get() + header_buffer_length_, header_data, len);
- header_buffer_length_ += len;
- return true;
- }
-
void OnSynStream(SpdyStreamId stream_id,
SpdyStreamId associated_stream_id,
SpdyPriority priority,
« no previous file with comments | « net/spdy/spdy_framer_decoder_adapter.cc ('k') | net/spdy/spdy_no_op_visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698