Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2438143002: Record a user action when a content intent is sent (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record a user action when a content intent is sent If the user activates a content detector for a phone number, address, or email address, record a user action when the intent is sent. BUG=657852 Committed: https://crrev.com/e2cf786bb19426e44fe22a36fb8d509ea04d1e62 Cr-Commit-Position: refs/heads/master@{#426801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Theresa
ptal
4 years, 2 months ago (2016-10-20 21:06:44 UTC) #2
aelias_OOO_until_Jul13
What metric are you planning to use as the denominator for this? Usually, it's better ...
4 years, 2 months ago (2016-10-20 21:59:00 UTC) #3
Theresa
On 2016/10/20 21:59:00, aelias wrote: > What metric are you planning to use as the ...
4 years, 2 months ago (2016-10-20 22:22:28 UTC) #4
aelias_OOO_until_Jul13
OK, lgtm.
4 years, 2 months ago (2016-10-20 22:27:48 UTC) #5
Theresa
+rkaplow@ for actions.xml
4 years, 2 months ago (2016-10-20 22:40:50 UTC) #7
rkaplow
lgtm
4 years, 2 months ago (2016-10-21 15:24:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438143002/1
4 years, 2 months ago (2016-10-21 15:26:50 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 15:51:00 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 16:04:48 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2cf786bb19426e44fe22a36fb8d509ea04d1e62
Cr-Commit-Position: refs/heads/master@{#426801}

Powered by Google App Engine
This is Rietveld 408576698