Update enabled state of the NTP search box whenever its alpha changes.

Update enabled state of the NTP search box whenever its alpha changes.

Previously it would only get updated on scrolling, but the toolbar can change
the search box visibility under other circumstances (eg. orientation changes)
as well.

BUG=656502
Committed: https://crrev.com/a8eec1e53109f1ba896a1d7998b5c290d1dcafcf
Cr-Commit-Position: refs/heads/master@{#426769}

[Bernhard Bauer, 2016-10-20 17:48:33]

Description was changed from

==========
fix?

BUG=
==========

to

==========
Update enabled state of the NTP search box whenever its alpha changes.

Previously it would only get updated on scrolling, but the toolbar can change
the search box visibility under other circumstances (eg. orientation changes)
as well.

BUG=656502
==========

[Bernhard Bauer, 2016-10-20 17:48:49]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:35:56]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-21 10:18:24]

bauerb@chromium.org changed reviewers:
+ peconn@chromium.org

[Bernhard Bauer, 2016-10-21 10:18:25]

And another one. Please review :)

[PEConn, 2016-10-21 10:22:32]

On 2016/10/21 10:18:25, Bernhard Bauer wrote:
> And another one. Please review :)

Assuming you've tested this on tablet for the original bug (that the fakebox was
still clickable when it was fading out), LGTM.

[Bernhard Bauer, 2016-10-21 11:10:42]

On 2016/10/21 10:22:32, PEConn wrote:
> On 2016/10/21 10:18:25, Bernhard Bauer wrote:
> > And another one. Please review :)
> 
> Assuming you've tested this on tablet for the original bug (that the fakebox
was
> still clickable when it was fading out), LGTM.

Yup, the fakebox is not clickable when it's fading out. 

There is the issue that the microphone button will be greyed out as soon as the
transition starts, but I think that was already the case before this CL. Also,
it still feels weird to be able to leave the fakebox in a transparent state.
Maybe we should modify the snap scrolling on tablets to avoid that…

[Bernhard Bauer, 2016-10-21 11:10:51]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-10-21 11:11:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 11:25:17]

Description was changed from

==========
Update enabled state of the NTP search box whenever its alpha changes.

Previously it would only get updated on scrolling, but the toolbar can change
the search box visibility under other circumstances (eg. orientation changes)
as well.

BUG=656502
==========

to

==========
Update enabled state of the NTP search box whenever its alpha changes.

Previously it would only get updated on scrolling, but the toolbar can change
the search box visibility under other circumstances (eg. orientation changes)
as well.

BUG=656502
==========

[commit-bot: I haz the power, 2016-10-21 11:25:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:28:48]

Description was changed from

==========
Update enabled state of the NTP search box whenever its alpha changes.

Previously it would only get updated on scrolling, but the toolbar can change
the search box visibility under other circumstances (eg. orientation changes)
as well.

BUG=656502
==========

to

==========
Update enabled state of the NTP search box whenever its alpha changes.

Previously it would only get updated on scrolling, but the toolbar can change
the search box visibility under other circumstances (eg. orientation changes)
as well.

BUG=656502

Committed: https://crrev.com/a8eec1e53109f1ba896a1d7998b5c290d1dcafcf
Cr-Commit-Position: refs/heads/master@{#426769}
==========

[commit-bot: I haz the power, 2016-10-21 13:28:49]

Patchset 1 (id:??) landed as
https://crrev.com/a8eec1e53109f1ba896a1d7998b5c290d1dcafcf
Cr-Commit-Position: refs/heads/master@{#426769}