Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2438053002: Fix checkbox ink drop ripple for RTL. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix checkbox ink drop ripple for RTL. BUG=655574 Committed: https://crrev.com/f7723387a069c61c42d80c433b55e4e24e3e9512 Cr-Commit-Position: refs/heads/master@{#426593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/controls/button/checkbox.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
4 years, 2 months ago (2016-10-20 16:55:54 UTC) #2
sadrul
lgtm
4 years, 2 months ago (2016-10-20 19:05:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438053002/1
4 years, 2 months ago (2016-10-20 19:42:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 21:01:06 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:22:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7723387a069c61c42d80c433b55e4e24e3e9512
Cr-Commit-Position: refs/heads/master@{#426593}

Powered by Google App Engine
This is Rietveld 408576698