Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2438033002: Ntp: tweak "all dismissed" spacing for latest mock. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: tweak "all dismissed" spacing for latest mock. BUG=651058 Committed: https://crrev.com/f8003d49d2e17ffa67c566001d8ca454c2d80e79 Cr-Commit-Position: refs/heads/master@{#426482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/res/layout/new_tab_page_all_dismissed.xml View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 2 months ago (2016-10-20 13:04:23 UTC) #4
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-20 13:28:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033002/1
4 years, 2 months ago (2016-10-20 13:35:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164701)
4 years, 2 months ago (2016-10-20 14:40:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438033002/1
4 years, 2 months ago (2016-10-20 14:55:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 15:42:37 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:18:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8003d49d2e17ffa67c566001d8ca454c2d80e79
Cr-Commit-Position: refs/heads/master@{#426482}

Powered by Google App Engine
This is Rietveld 408576698