Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2437953002: Support xctests on simulators (Closed)

Created:
4 years, 2 months ago by smut
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support xctests on simulators xctest_utils.py is copied from chromium/tools/build/scripts/slave/ios/xctest_utils.py. BUG=608537 Committed: https://crrev.com/a02a2039a04b4bafd020ee80ff088be27cf3bdf7 Cr-Commit-Position: refs/heads/master@{#426933}

Patch Set 1 #

Patch Set 2 : Allow --xctest to be specified in --args-json #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -237 lines) Patch
M ios/build/bots/scripts/gtest_utils.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/build/bots/scripts/run.py View 1 3 chunks +7 lines, -0 lines 0 comments Download
M ios/build/bots/scripts/test_runner.py View 13 chunks +52 lines, -6 lines 0 comments Download
A + ios/build/bots/scripts/xctest_utils.py View 1 2 11 chunks +22 lines, -230 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
smut
Tested by copying over to bots and launching chrome_eg_smoke_tests_host.app on a simulator. Ran two test ...
4 years, 2 months ago (2016-10-20 00:50:21 UTC) #2
huangml1
Do we need to change the recipe as well if the args in run.py is ...
4 years, 2 months ago (2016-10-20 01:20:11 UTC) #4
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-20 05:30:41 UTC) #6
smut
On 2016/10/20 01:20:11, huangml1 wrote: > Do we need to change the recipe as well ...
4 years, 2 months ago (2016-10-21 21:29:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437953002/20001
4 years, 2 months ago (2016-10-21 21:29:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437953002/40001
4 years, 2 months ago (2016-10-21 21:32:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287211)
4 years, 2 months ago (2016-10-21 22:07:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437953002/60001
4 years, 2 months ago (2016-10-21 22:25:43 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-22 00:13:36 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 00:21:44 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a02a2039a04b4bafd020ee80ff088be27cf3bdf7
Cr-Commit-Position: refs/heads/master@{#426933}

Powered by Google App Engine
This is Rietveld 408576698