Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2437873004: Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcoder… (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428043002/ )" The performance regression in crbug.com/657776 was not caused by this CL. This reverts commit 4490a7601c81647a4fb93da94360f271eb172473. BUG= Committed: https://crrev.com/189794ddb289029b224be64cd0dddb3487fae371 Cr-Commit-Position: refs/heads/master@{#40478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -75 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 4 chunks +10 lines, -24 lines 0 comments Download
M src/heap/mark-compact.cc View 12 chunks +34 lines, -43 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
ptal
4 years, 2 months ago (2016-10-20 15:33:45 UTC) #2
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-20 15:48:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437873004/1
4 years, 2 months ago (2016-10-20 15:49:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 16:24:51 UTC) #6
ulan
A revert of this CL (patchset #1 id:1) has been created in https://chromiumcodereview.appspot.com/2446583003/ by ulan@chromium.org. ...
4 years, 1 month ago (2016-10-24 14:30:11 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/189794ddb289029b224be64cd0dddb3487fae371
Cr-Commit-Position: refs/heads/master@{#40478}

Powered by Google App Engine
This is Rietveld 408576698