Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2437733002: Move DivisionByConstant template instantiations to cpp file (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move DivisionByConstant template instantiations to cpp file R=bmeurer@chromium.org BUG= Committed: https://crrev.com/e4ac0105b8868317ef58c397a4469fe288331c5a Cr-Commit-Position: refs/heads/master@{#40436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/base/division-by-constant.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/base/division-by-constant.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 2 months ago (2016-10-19 12:25:52 UTC) #1
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-19 12:26:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437733002/1
4 years, 2 months ago (2016-10-19 12:26:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 13:32:20 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4ac0105b8868317ef58c397a4469fe288331c5a
Cr-Commit-Position: refs/heads/master@{#40436}

Powered by Google App Engine
This is Rietveld 408576698