arc: Add URL converter functions

arc: Add URL converter functions

When receiving a content: URL or a file: URL from ARC,
these functions will be used to convert the URL to an externalfile: URL
to display the contents on a Chrome tab.

BUG=654684
Committed: https://crrev.com/b94e929572960bae4c96de14342e9a5efc2d0995
Cr-Commit-Position: refs/heads/master@{#426724}

[hashimoto, 2016-10-19 08:33:23]

Patchset #1 (id:1) has been deleted

[hashimoto, 2016-10-19 08:33:32]

hashimoto@chromium.org changed reviewers:
+ hidehiko@chromium.org

[hashimoto, 2016-10-19 08:33:40]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 09:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 12:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 12:44:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hidehiko, 2016-10-20 05:28:19]

Sorry for delay. LGTM.

https://codereview.chromium.org/2437693002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util_unittest.cc
(right):

https://codereview.chromium.org/2437693002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util_unittest.cc:52:
utf16_string.push_back(0x307b);  // HIRAGANA_LETTER_HO
optional: Can this be initializer_list?

https://codereview.chromium.org/2437693002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/fileapi/external_file_url_util.h (right):

https://codereview.chromium.org/2437693002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/fileapi/external_file_url_util.h:36: GURL
VirtualPathToExternalFileURL(const base::FilePath& virtual_path);
unittest, too, if this is used as a utility from outside?

[hashimoto, 2016-10-20 08:36:10]

hashimoto@chromium.org changed reviewers:
+ mtomasz@chromium.org

[hashimoto, 2016-10-20 08:36:11]

mtomasz@, could you review chrome/browser/chromeos/fileapi?

https://chromiumcodereview.appspot.com/2437693002/diff/20001/chrome/browser/c...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util_unittest.cc
(right):

https://chromiumcodereview.appspot.com/2437693002/diff/20001/chrome/browser/c...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util_unittest.cc:52:
utf16_string.push_back(0x307b);  // HIRAGANA_LETTER_HO
On 2016/10/20 05:28:19, hidehiko wrote:
> optional: Can this be initializer_list?

Done.

https://chromiumcodereview.appspot.com/2437693002/diff/20001/chrome/browser/c...
File chrome/browser/chromeos/fileapi/external_file_url_util.h (right):

https://chromiumcodereview.appspot.com/2437693002/diff/20001/chrome/browser/c...
chrome/browser/chromeos/fileapi/external_file_url_util.h:36: GURL
VirtualPathToExternalFileURL(const base::FilePath& virtual_path);
On 2016/10/20 05:28:19, hidehiko wrote:
> unittest, too, if this is used as a utility from outside?

Done.

[hidehiko, 2016-10-20 08:41:29]

Still lgtm.

[mtomasz, 2016-10-20 08:55:05]

lgtm

https://chromiumcodereview.appspot.com/2437693002/diff/60001/chrome/browser/c...
File chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc
(right):

https://chromiumcodereview.appspot.com/2437693002/diff/60001/chrome/browser/c...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc:13:
const char kMountPointName[] = "arc-content";
nit: Can this be constexpr and/or anonymous namespace?

[hashimoto, 2016-10-20 09:26:45]

https://chromiumcodereview.appspot.com/2437693002/diff/60001/chrome/browser/c...
File chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc
(right):

https://chromiumcodereview.appspot.com/2437693002/diff/60001/chrome/browser/c...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc:13:
const char kMountPointName[] = "arc-content";
On 2016/10/20 08:55:05, mtomasz wrote:
> nit: Can this be constexpr and/or anonymous namespace?

Later this will be used to add a mount to chromeos::FileSystemBackend, though
ATM it's only used in this file.
Put it into an anonymous namespace

[hashimoto, 2016-10-21 02:29:23]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2016-10-21 02:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/2437693002/#ps80001
(title: "Anonymous namespace")

[commit-bot: I haz the power, 2016-10-21 02:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:54:11]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:27:20]

Description was changed from

==========
arc: Add URL converter functions

When receiving a content: URL or a file: URL from ARC,
these functions will be used to convert the URL to an externalfile: URL
to display the contents on a Chrome tab.

BUG=654684
==========

to

==========
arc: Add URL converter functions

When receiving a content: URL or a file: URL from ARC,
these functions will be used to convert the URL to an externalfile: URL
to display the contents on a Chrome tab.

BUG=654684

Committed: https://crrev.com/b94e929572960bae4c96de14342e9a5efc2d0995
Cr-Commit-Position: refs/heads/master@{#426724}
==========

[commit-bot: I haz the power, 2016-10-21 13:27:21]

Patchset 4 (id:??) landed as
https://crrev.com/b94e929572960bae4c96de14342e9a5efc2d0995
Cr-Commit-Position: refs/heads/master@{#426724}