[turbofan] Make FrameStateBeforeAndAfter explicit.

[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array creation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org

Committed: https://crrev.com/c44dca798b36f090c370c3e88146ad7a1ce8a1b4
Cr-Commit-Position: refs/heads/master@{#40453}

[Michael Starzinger, 2016-10-19 11:56:56]

Description was changed from

==========
[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array generation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org
==========

to

==========
[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array creation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org
==========

[Michael Starzinger, 2016-10-19 12:04:06]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 12:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-10-19 12:08:48]

mstarzinger@chromium.org changed reviewers:
+ leszeks@chromium.org

[Jarin, 2016-10-19 12:22:56]

lgtm

[commit-bot: I haz the power, 2016-10-19 13:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 13:09:38]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-10-20 08:15:32]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:15:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 08:22:38]

Description was changed from

==========
[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array creation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org
==========

to

==========
[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array creation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org
==========

[commit-bot: I haz the power, 2016-10-20 08:22:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:07:21]

Description was changed from

==========
[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array creation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org
==========

to

==========
[turbofan] Make FrameStateBeforeAndAfter explicit.

This makes the creation of frame states "before" and "after" node
sequences explicit in the {BytecodeGraphBuilder}. This removes some
complexity and also allows us to ellide redundant {Checkpoint} nodes
before operations that don't actually eager deoptimize.

In this change such redundant {Checkpoint} nodes have been removed for
arguments object and rest array creation bytecodes. The frame states
used in such {Checkpoint} nodes were actually bogus because they would
resume bytecode execution before the {new.target} value is assigned to
its respective variable.

R=jarin@chromium.org

Committed: https://crrev.com/c44dca798b36f090c370c3e88146ad7a1ce8a1b4
Cr-Commit-Position: refs/heads/master@{#40453}
==========

[commit-bot: I haz the power, 2016-11-17 22:07:22]

Patchset 2 (id:??) landed as
https://crrev.com/c44dca798b36f090c370c3e88146ad7a1ce8a1b4
Cr-Commit-Position: refs/heads/master@{#40453}