Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2437633003: [DevTools] Switch remote locations to Target domain. (Closed)
Patch Set: removed dispose Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | content/browser/devtools/protocol/browser_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index f8903d9074c293658fce32602d76797f8fe33e2b..0e220b1bd28886bc2cf1420c4d8f226d47f07969 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -560,6 +560,7 @@ void DevToolsWindow::OpenExternalFrontend(
if (!window)
return;
window->bindings_->AttachTo(agent_host);
+ window->close_on_detach_ = false;
}
window->ScheduleShow(DevToolsToggleAction::Show());
@@ -778,6 +779,7 @@ DevToolsWindow::DevToolsWindow(Profile* profile,
browser_(nullptr),
is_docked_(true),
can_dock_(can_dock),
+ close_on_detach_(true),
// This initialization allows external front-end to work without changes.
// We don't wait for docking call, but instead immediately show undocked.
// Passing "dockSide=undocked" parameter ensures proper UI.
@@ -1198,6 +1200,8 @@ void DevToolsWindow::SetWhitelistedShortcuts(
}
void DevToolsWindow::InspectedContentsClosing() {
+ if (!close_on_detach_)
+ return;
intercepted_page_beforeunload_ = false;
life_stage_ = kClosing;
main_web_contents_->ClosePage();
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | content/browser/devtools/protocol/browser_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698