content/browser/accessibility/accessibility_tree_formatter_blink.cc - Issue 2437473003: Fixed line start offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_blink.cc

Issue 2437473003: Fixed line start offsets. (Closed)

Patch Set: Fixed tests and nits. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js ('k') | ui/accessibility/ax_node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_tree_formatter_blink.cc

diff --git a/content/browser/accessibility/accessibility_tree_formatter_blink.cc b/content/browser/accessibility/accessibility_tree_formatter_blink.cc

index 00d9a0693847085b85d48198cbd752c625420ad1..5e9c8bd4f26563b69e6dc6f37810993ab4882982 100644

--- a/content/browser/accessibility/accessibility_tree_formatter_blink.cc

+++ b/content/browser/accessibility/accessibility_tree_formatter_blink.cc

@@ -40,6 +40,9 @@ void AccessibilityTreeFormatterBlink::AddProperties(

const BrowserAccessibility& node,

base::DictionaryValue* dict) {

dict->SetInteger("id", node.GetId());

+ auto lines = node.GetLineStartOffsets();

+ for (auto& l : lines)

+ DLOG(ERROR) << "Nektar: ui::ToString(node.GetData().role)" << l;

dict->SetString("internalRole", ui::ToString(node.GetData().role));

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js ('k') | ui/accessibility/ax_node.h » ('j') | no next file with comments »