Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2437423002: Move NewLoginRequest plumbing to AwContentsClientBridge (Closed)

Created:
4 years, 2 months ago by sgurun-gerrit only
Modified:
4 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NewLoginRequest plumbing to AwContentsClientBridge This is the continuation of the work described in https://codereview.chromium.org/2425423004/. This moves NewLoginRequest out of AwContentsIoThreadClient. BUG=645983 Committed: https://crrev.com/a0039eafcbc9329d0559e5ac2247501c7f522430 Cr-Commit-Position: refs/heads/master@{#426898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M android_webview/browser/aw_contents_client_bridge_base.h View 3 chunks +11 lines, -0 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge_base.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M android_webview/browser/aw_contents_io_thread_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 2 chunks +18 lines, -9 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +0 lines, -5 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sgurun-gerrit only
On 2016/10/21 19:46:48, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:boliu@chromium.org ptal, thanks
4 years, 2 months ago (2016-10-21 19:46:57 UTC) #3
boliu
lgtm
4 years, 2 months ago (2016-10-21 20:14:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437423002/1
4 years, 2 months ago (2016-10-21 20:38:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 21:47:47 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 21:52:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0039eafcbc9329d0559e5ac2247501c7f522430
Cr-Commit-Position: refs/heads/master@{#426898}

Powered by Google App Engine
This is Rietveld 408576698