Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2437393002: Remove ash::ShellDelegate::IsFirstRunAfterBoot method (Closed)

Created:
4 years, 1 month ago by James Cook
Modified:
4 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ash::ShellDelegate::IsFirstRunAfterBoot method This allows me to skip refactoring it for mustash. It also avoids one place where chrome calls back into ash that I would have to refactor as well. The method just looks up a chromeos command-line switch, so inline that lookup where needed. In addition, clean up some of the splash screen init logic to make it more clear how we handle primary vs. secondary displays. BUG=none TEST=run chrome with and without --first-exec-after-boot, watch background colors as displays are initialized Committed: https://crrev.com/fda15900d2cead86a689f7b93607139777fe38cd Cr-Commit-Position: refs/heads/master@{#426854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -47 lines) Patch
M ash/common/shell_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/root_window_controller.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ash/root_window_controller.cc View 5 chunks +16 lines, -9 lines 0 comments Download
M ash/shell.cc View 3 chunks +6 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/display/display_configuration_observer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
derat, please take a look.
4 years, 1 month ago (2016-10-21 17:32:14 UTC) #4
Daniel Erat
lgtm
4 years, 1 month ago (2016-10-21 17:38:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437393002/1
4 years, 1 month ago (2016-10-21 17:40:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-21 18:49:24 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 19:08:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fda15900d2cead86a689f7b93607139777fe38cd
Cr-Commit-Position: refs/heads/master@{#426854}

Powered by Google App Engine
This is Rietveld 408576698