Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2437223002: Revert of Make PaymentOption store a Drawable instead of id (Closed)

Created:
4 years, 2 months ago by Dmitry Skiba
Modified:
4 years, 2 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make PaymentOption store a Drawable instead of id (patchset #4 id:100001 of https://codereview.chromium.org/2436883002/ ) Reason for revert: This broke internal class (which relied on 'icon' being int). Please coordinate with rouslan@ to push a fix right after relanding. Original issue's description: > Make PaymentOption store a Drawable instead of id > > Make PaymentOption store a Drawable instead of id for the icon. > This will allow to use icons not contained in the default resources. > > BUG=587995 TBR=rouslan@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,rob.buis@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587995 Committed: https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f Cr-Commit-Position: refs/heads/master@{#426618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -64 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 4 chunks +6 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java View 4 chunks +14 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java View 7 chunks +11 lines, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dmitry Skiba
Created Revert of Make PaymentOption store a Drawable instead of id
4 years, 2 months ago (2016-10-20 22:18:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437223002/1
4 years, 2 months ago (2016-10-20 22:19:13 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-20 22:19:15 UTC) #5
please use gerrit instead
lgtm I will reland and fix the internals shortly sometime on Friday.
4 years, 2 months ago (2016-10-20 22:20:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437223002/1
4 years, 2 months ago (2016-10-20 22:21:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 22:22:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/403cce524dcb11fb72bed9f0f1ff30219b8b824f
Cr-Commit-Position: refs/heads/master@{#426618}

Powered by Google App Engine
This is Rietveld 408576698