Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2437213002: Fix crash where a pending pointer lock would trigger a CHECK. (Closed)

Created:
4 years, 2 months ago by lfg
Modified:
4 years, 2 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash where a pending pointer lock would trigger a CHECK. This change makes sure that we gracefully handle the case where a pending pointer lock request is still active while destroying the RenderWidgetHost. BUG=655592 Committed: https://crrev.com/ff8dfc8dad9f98b4022c1108335820204fee3c70 Cr-Commit-Position: refs/heads/master@{#426835}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
lfg
Nick, can you take a look?
4 years, 2 months ago (2016-10-21 15:14:05 UTC) #14
ncarter (slow)
lgtm
4 years, 2 months ago (2016-10-21 17:21:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437213002/40001
4 years, 2 months ago (2016-10-21 17:21:36 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-21 17:42:55 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 18:06:47 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff8dfc8dad9f98b4022c1108335820204fee3c70
Cr-Commit-Position: refs/heads/master@{#426835}

Powered by Google App Engine
This is Rietveld 408576698