Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2437193002: Log to UMA why we would load a third-party frame (Closed)
Patch Set: don't copy SimRequest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 0844a8866f7e44e8c80e1de6abf56ca11efc538d..40ec07d36da6841e83fe3673db9bcf585c886645 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -236,6 +236,29 @@ enum CreateElementFlags {
CreatedByFragmentParser = CreatedByParser | AsynchronousCustomElements,
};
+// Collect data about deferred loading of offscreen cross-origin documents. All
+// cross-origin documents log Created. Only those that would load log a reason.
+// We can then see the % of cross-origin documents that never have to load.
+// See https://crbug.com/635105.
+// Logged to UMA, don't re-arrange entries without creating a new histogram.
+enum WouldLoadReason {
+ Created,
+ // If outer and inner frames aren't in the same process we can't determine
+ // if the inner frame is visible, so just load it.
+ // TODO(dgrogan): Revisit after https://crbug.com/650433 is fixed.
+ WouldLoadOutOfProcess,
+ // The next four indicate frames that are probably used for cross-origin
+ // communication.
+ WouldLoadDisplayNone,
+ WouldLoadZeroByZero,
+ WouldLoadAbove,
+ WouldLoadLeft,
+ // We have to load documents in visible frames.
+ WouldLoadVisible,
+
+ WouldLoadReasonEnd
+};
+
using DocumentClassFlags = unsigned char;
class CORE_EXPORT Document : public ContainerNode,
@@ -1286,7 +1309,8 @@ class CORE_EXPORT Document : public ContainerNode,
bool isInMainFrame() const;
- void onVisibilityMaybeChanged(bool visible);
+ void maybeRecordLoadReason(WouldLoadReason);
+ WouldLoadReason wouldLoadReason() { return m_wouldLoadReason; }
PropertyRegistry* propertyRegistry();
@@ -1641,7 +1665,7 @@ class CORE_EXPORT Document : public ContainerNode,
Member<SnapCoordinator> m_snapCoordinator;
- bool m_visibilityWasLogged;
+ WouldLoadReason m_wouldLoadReason;
Member<PropertyRegistry> m_propertyRegistry;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698