Do not test suggestion orientation on JB

Do not test suggestion orientation on JB

JellyBean (SDK level 16) is hardcoded to always return
LAYOUT_DIRECTION_LTR when checking layout direction.
This change disables layout direction checking for those
devices.

BUG=657932
Committed: https://crrev.com/fb65d4ce8c258089c80007408132ef89100eecd8
Cr-Commit-Position: refs/heads/master@{#426587}

[kraush, 2016-10-20 18:29:01]

kraush@amazon.com changed reviewers:
+ tedchoc@chromium.org

[kraush, 2016-10-20 18:29:02]

Hi Ted,

Can you take a look at this test fix for JellyBean devices?

Thanks! :)
Holger

[Ted C, 2016-10-20 19:15:49]

https://codereview.chromium.org/2437153002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
(right):

https://codereview.chromium.org/2437153002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java:659:
public void testSuggestionDirectionSwitching() throws InterruptedException {
Should we just be disabling this test for JB devices?

@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.JELLY_BEAN_MR1)

We're not actually doing the validation here, so I think just not running it
makes more sense.

[kraush, 2016-10-20 19:20:29]

On 2016/10/20 19:15:49, Ted C wrote:
>
https://codereview.chromium.org/2437153002/diff/1/chrome/android/javatests/sr...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
> (right):
> 
>
https://codereview.chromium.org/2437153002/diff/1/chrome/android/javatests/sr...
>
chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java:659:
> public void testSuggestionDirectionSwitching() throws InterruptedException {
> Should we just be disabling this test for JB devices?
> 
> @DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.JELLY_BEAN_MR1)
> 
> We're not actually doing the validation here, so I think just not running it
> makes more sense.

Makes sense!
I'll upload a new diff where the test is disabled for < JB MR1

[kraush, 2016-10-20 19:23:59]

Hi Ted,

Can you take a look at this new revision which disables the test (on SDK 16)
rather than skipping parts of it?

Thanks!
Holger

[Ted C, 2016-10-20 20:01:05]

lgtm...didn't know about MinAndroidSdkLevel.  cool!

[kraush, 2016-10-20 20:07:33]

The CQ bit was checked by kraush@amazon.com

[commit-bot: I haz the power, 2016-10-20 20:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 20:51:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:22:08]

Description was changed from

==========
Do not test suggestion orientation on JB

JellyBean (SDK level 16) is hardcoded to always return
LAYOUT_DIRECTION_LTR when checking layout direction.
This change disables layout direction checking for those
devices.

BUG=657932
==========

to

==========
Do not test suggestion orientation on JB

JellyBean (SDK level 16) is hardcoded to always return
LAYOUT_DIRECTION_LTR when checking layout direction.
This change disables layout direction checking for those
devices.

BUG=657932

Committed: https://crrev.com/fb65d4ce8c258089c80007408132ef89100eecd8
Cr-Commit-Position: refs/heads/master@{#426587}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:08]

Patchset 2 (id:??) landed as
https://crrev.com/fb65d4ce8c258089c80007408132ef89100eecd8
Cr-Commit-Position: refs/heads/master@{#426587}