Clears Android keyboard when user touches any of the dropdown menu views.

Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration month.

BUG=623563
Committed: https://crrev.com/d0803376130bda68eb594d02ebaca4609e3f899e
Cr-Commit-Position: refs/heads/master@{#426927}

[csashi, 2016-10-21 16:45:25]

Description was changed from

==========
Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration
month.

BUG=623563
==========

to

==========
Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration
month.

BUG=623563
==========

[csashi, 2016-10-21 16:45:25]

csashi@google.com changed reviewers:
+ twellington@chromium.org

[csashi, 2016-10-21 16:45:49]

Hi Theresa, PTAL.
Thanks.

[Theresa, 2016-10-21 18:56:03]

https://codereview.chromium.org/2437143004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/2437143004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:93:
//
http://stackoverflow.com/questions/1109022/close-hide-the-android-soft-keyboard
nit: I don't think the code needs to reference stack overflow in a comment.

https://codereview.chromium.org/2437143004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:94:
InputMethodManager imm =
All of this should probably be enclosed in an if statement so that the logic
applies specifically to the drop down views. This will guard against
accidentally dismissing the keyboard if we make this class an touch listener for
other fields in the future.

The check could be for explicit views or maybe for "v instanceof Spinner".


Also, should we apply this logic to the country drop down in
AutofillProfileEditor as well? It'd be great to have the same behavior for all
of the drop downs in these forms. AutofillEditorBase could contain the onTouch
method.

[csashi, 2016-10-21 19:48:42]

Hi Theresa,
PTAL. Thanks,
-sashi.

https://codereview.chromium.org/2437143004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/2437143004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:93:
//
http://stackoverflow.com/questions/1109022/close-hide-the-android-soft-keyboard
On 2016/10/21 18:56:03, Theresa Wellington wrote:
> nit: I don't think the code needs to reference stack overflow in a comment.

Done.

https://codereview.chromium.org/2437143004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:94:
InputMethodManager imm =
On 2016/10/21 18:56:03, Theresa Wellington wrote:
> All of this should probably be enclosed in an if statement so that the logic
> applies specifically to the drop down views. This will guard against
> accidentally dismissing the keyboard if we make this class an touch listener
for
> other fields in the future.
> 
> The check could be for explicit views or maybe for "v instanceof Spinner".
> 
> 
> Also, should we apply this logic to the country drop down in
> AutofillProfileEditor as well? It'd be great to have the same behavior for all
> of the drop downs in these forms. AutofillEditorBase could contain the onTouch
> method.

Done.

[Theresa, 2016-10-21 21:03:10]

lgtm % one nit

https://codereview.chromium.org/2437143004/diff/10001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
(right):

https://codereview.chromium.org/2437143004/diff/10001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java:100:
v.performClick();
Does v.performClick() need to be called? Since we're returning false below, I
assume that the touch event isn't being consumed and will continue being
propagated to the view.

[csashi, 2016-10-21 21:30:33]

Hi Theresa,
PTAL. Thanks.

https://codereview.chromium.org/2437143004/diff/10001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
(right):

https://codereview.chromium.org/2437143004/diff/10001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java:100:
v.performClick();
On 2016/10/21 21:03:10, Theresa Wellington wrote:
> Does v.performClick() need to be called? Since we're returning false below, I
> assume that the touch event isn't being consumed and will continue being
> propagated to the view.

Done.

[Theresa, 2016-10-21 21:45:01]

lgtm

[csashi, 2016-10-21 21:48:06]

The CQ bit was checked by csashi@google.com

[commit-bot: I haz the power, 2016-10-21 21:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 23:31:10]

Description was changed from

==========
Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration
month.

BUG=623563
==========

to

==========
Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration
month.

BUG=623563
==========

[commit-bot: I haz the power, 2016-10-21 23:31:11]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-10-21 23:35:09]

Description was changed from

==========
Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration
month.

BUG=623563
==========

to

==========
Clears Android keyboard when user touches any of the dropdown menu views.
Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration
month.

BUG=623563

Committed: https://crrev.com/d0803376130bda68eb594d02ebaca4609e3f899e
Cr-Commit-Position: refs/heads/master@{#426927}
==========

[commit-bot: I haz the power, 2016-10-21 23:35:10]

Patchset 3 (id:??) landed as
https://crrev.com/d0803376130bda68eb594d02ebaca4609e3f899e
Cr-Commit-Position: refs/heads/master@{#426927}

[csashi, 2016-10-25 19:04:41]

Patchset #4 (id:50001) has been deleted