Dereference and std::move in same param list == top crasher

Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move of the same unique_ptr in the same parameter list. The order of evalulation is unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org

Committed: https://crrev.com/884c98b01d2daebaa2f519300d3f64b2850f31fe
Cr-Commit-Position: refs/heads/master@{#426553}

[Roger McFarlane (Chromium), 2016-10-20 17:40:14]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2016-10-20 17:45:59]

PTAL?

[Roger McFarlane (Chromium), 2016-10-20 17:46:28]

rogerm@chromium.org changed reviewers:
+ vabr@chromium.org

[Roger McFarlane (Chromium), 2016-10-20 17:46:28]

+vabr

[vabr (Chromium), 2016-10-20 17:47:51]

LGTM!

[Roger McFarlane (Chromium), 2016-10-20 17:49:37]

Description was changed from

==========
Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and
a std::move of hte same unique_ptr in the same parameter list. The
order of evalulation is unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org
==========

to

==========
Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move
of the same unique_ptr in the same parameter list. The order of evalulation is
unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org
==========

[Roger McFarlane (Chromium), 2016-10-20 17:50:26]

The CQ bit was unchecked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2016-10-20 17:50:34]

The CQ bit was checked by rogerm@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-20 18:30:40]

On 2016/10/20 17:51:14, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Yes! Thank you for fixing it.

[commit-bot: I haz the power, 2016-10-20 19:03:38]

Description was changed from

==========
Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move
of the same unique_ptr in the same parameter list. The order of evalulation is
unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org
==========

to

==========
Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move
of the same unique_ptr in the same parameter list. The order of evalulation is
unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org
==========

[commit-bot: I haz the power, 2016-10-20 19:03:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:20:59]

Description was changed from

==========
Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move
of the same unique_ptr in the same parameter list. The order of evalulation is
unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org
==========

to

==========
Dereference and std::move in same param list == top crasher

Fix a top crasher (2016/10/20) caused by defer of a unique_ptr and a std::move
of the same unique_ptr in the same parameter list. The order of evalulation is
unspecified, so this is unsafe.

BUG=657778
R=ajha@chromium.org, avi@chromium.org

Committed: https://crrev.com/884c98b01d2daebaa2f519300d3f64b2850f31fe
Cr-Commit-Position: refs/heads/master@{#426553}
==========

[commit-bot: I haz the power, 2016-10-21 13:21:00]

Patchset 1 (id:??) landed as
https://crrev.com/884c98b01d2daebaa2f519300d3f64b2850f31fe
Cr-Commit-Position: refs/heads/master@{#426553}